798 sort out units of specific heat air latent heat vapourisation density of air

[vgro]

There were inconsistencies with the use of a few variables. I fixed hydrology and abiotic, @jacobcook1995 and @davidorme please check if your models are affected.

Fixes #798

Type of change

• New feature (non-breaking change which adds functionality)
• Optimization (back-end change that speeds up the code)
• Bug fix (non-breaking change which fixes an issue)

Key checklist

• Make sure you've run the pre-commit checks: $ pre-commit run -a
• All tests pass: $ poetry run pytest

Further checks

• Code is commented, particularly in hard-to-understand areas
• Tests added that prove fix is effective or that feature works
• Relevant documentation reviewed and updated

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.62%. Comparing base (60d58d5) to head (b7b1b06).
⚠️ Report is 2374 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #800      +/-   ##
===========================================
+ Coverage    94.61%   94.62%   +0.01%     
===========================================
  Files           74       74              
  Lines         5104     5102       -2     
===========================================
- Hits          4829     4828       -1     
+ Misses         275      274       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[jacobcook1995]

The changes look sensible to me!

I don't think any of this touches on my model though, I use a "gas constant" but that's from thermodynamics so doesn't relate to any real gas. I guess @davidorme might be more effected though

[davidorme]

I think I'm good too - I care about atmospheric pressure in Pa and vapour pressure deficit in Pa.

[vgro]

I think I'm good too - I care about atmospheric pressure in Pa and vapour pressure deficit in Pa.

Are you happy with me merging this and changing the unit when you read in the data for now? We can also move to Pa everywhere but I would prefer moving that to a separate PR, this would affect a lot of files...

[vgro]

I think I'm good too - I care about atmospheric pressure in Pa and vapour pressure deficit in Pa.

Are you happy with me merging this and changing the unit when you read in the data for now? We can also move to Pa everywhere but I would prefer moving that to a separate PR, this would affect a lot of files...

I've created an issue (#802) to do this separately so I can move on with development of other parts. I will address this soon.