Average abiotic quantities over relevant soil layers#803
Conversation
…bially active soil layers
…reverted the soil water averaging function to being matric potential specific
…lly active soil depth
…ntities-over-relevant-soil-layers
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #803 +/- ##
========================================
Coverage 94.64% 94.65%
========================================
Files 74 74
Lines 5120 5127 +7
========================================
+ Hits 4846 4853 +7
Misses 274 274 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| # Find the fraction of each layer that lies within the microbially active zone | ||
| layer_weights = ( | ||
| layer_structure.soil_layer_active_thickness | ||
| / layer_structure.soil_layer_thickness |
There was a problem hiding this comment.
I think you might need to use the soil layer depth instead of the soil layer thickness here. If both layers are 1m thick, the depth of the first on is 1m, the depth of the second is 2m. if your microbial depth is then 1.2 m, you want all of the first layer but only 0.2 of the second layer, right? At the moment it looks like it always starts from zero?
There was a problem hiding this comment.
Okay, I'll add a note explaining what layer_structure.soil_layer_active_thickness is as that isn't really clear from the name alone
Description
This PR changes the soil model so that it averages abiotic quantities over the relevant soil layers. The temperature and matric potential averaging works the same as in the litter model. The soil moisture "averaging" is something I just added, so sanity checking that would be really appreciated!
Fixes #533
Type of change
Key checklist
pre-commitchecks:$ pre-commit run -a$ poetry run pytestFurther checks