Conversation
…than hard-coding, some new model attrs
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #827 +/- ##
===========================================
+ Coverage 95.13% 95.21% +0.07%
===========================================
Files 80 80
Lines 6722 6770 +48
===========================================
+ Hits 6395 6446 +51
+ Misses 327 324 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…legeLondon/virtual_ecosystem into add_cohorts_for_stochiometry
…ochiometry Stoichiometry recruitment
|
@sallymatson This is a bit of a monster now (although there have been worse!). I've reviewed all of the stochiometry stuff though, and tests pass. Could you review? |
|
The initial stem diameter is entirely arbitrary - we need to find some kind of initial DBH and stochiometry from the carbon and nutrients available in the propagule. We could set that as a trait, but it would be better to work it out from first principles using the T Model. |
sallymatson
left a comment
There was a problem hiding this comment.
LGTM. I had reviewed before I started the stoichiometry stuff and it all made sense to me then, and when I added as well.
Description
Since #812, we have had allocation of carbon to reproductive propagules in the plant model and numbers of propagules in the model.
This PR is to provide an initial draft of recruitment of new cohorts from those propagules:
apply_recruitmentmethod that uses the germination rate to convert propagules into seedlings and adds those seedlings as new cohorts to the Community object in the cell.Things to worry about later - probably convert each of these to its own issue
The initial stem diameter is entirely arbitrary - we need to find some kind of initial DBH and stochiometry from the carbon and nutrients available in the propagule. We could set that as a trait, but it would be better to work it out from first principles using the T Model.
[Converted to issue Plant initial stem diameter is arbitrary #1024]
The separation of the subcanopy vegetation and the seedlings. The light environment of these two different groups matters a lot to seedling success. If we go with an infinitely thin algal mat model for the subcanopy vegetation, then all seedlings are instantly above the subcanopy. That's easy to code but wildly inaccurate.
[This is what we are doing for now - @arne-exe and @davidorme have started discussing a shrub layer which would make this complex, but that's way down the line]
Check to see if empty cohorts are removed following mortality of all individuals. I don't think they are at present.
I'm still seeing bizarre errors in growth patterns. Something is up with the GPP units, I think.
Fixes #824
Type of change
Key checklist
pre-commitchecks:$ pre-commit run -a$ poetry run pytestFurther checks