Skip to content

replaced water_to_air_mass_ratio in abiotic constants with molecular_…#850

Merged
vgro merged 3 commits intodevelopfrom
849-remove-duplicated-constant
May 9, 2025
Merged

replaced water_to_air_mass_ratio in abiotic constants with molecular_…#850
vgro merged 3 commits intodevelopfrom
849-remove-duplicated-constant

Conversation

@vgro
Copy link
Copy Markdown
Collaborator

@vgro vgro commented May 9, 2025

…weight_ratio_water_to_dry_air from core constants

This PR replaces a duplicated constant.

Fixes #849

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works
  • Relevant documentation reviewed and updated

…weight_ratio_water_to_dry_air from core constants
@vgro vgro linked an issue May 9, 2025 that may be closed by this pull request
@vgro vgro requested a review from sallymatson May 9, 2025 08:29
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.76%. Comparing base (bd4c1f6) to head (dce08d3).
⚠️ Report is 2106 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #850      +/-   ##
===========================================
- Coverage    94.76%   94.76%   -0.01%     
===========================================
  Files           75       75              
  Lines         5563     5561       -2     
===========================================
- Hits          5272     5270       -2     
  Misses         291      291              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@sallymatson sallymatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@vgro vgro enabled auto-merge May 9, 2025 11:21
@vgro vgro merged commit 04bcf12 into develop May 9, 2025
16 checks passed
@vgro vgro deleted the 849-remove-duplicated-constant branch May 9, 2025 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

remove duplicated constant

3 participants