Skip to content

858 abiotic set initial constants based on data and add references and units#859

Merged
vgro merged 10 commits intodevelopfrom
858-abiotic-set-initial-constants-based-on-data-and-add-references-and-units
Jun 4, 2025
Merged

858 abiotic set initial constants based on data and add references and units#859
vgro merged 10 commits intodevelopfrom
858-abiotic-set-initial-constants-based-on-data-and-add-references-and-units

Conversation

@vgro
Copy link
Copy Markdown
Collaborator

@vgro vgro commented May 14, 2025

This PR updates the available static parameters for the abiotic model.
The documentation is here: https://virtual-ecosystem.readthedocs.io/en/858-abiotic-set-initial-constants-based-on-data-and-add-references-and-units/api/models/abiotic/abiotic_constants.html

Fixes #858

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works
  • Relevant documentation reviewed and updated

@vgro vgro linked an issue May 14, 2025 that may be closed by this pull request
@vgro vgro requested a review from lelavathy May 14, 2025 11:19
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.79%. Comparing base (d8c4808) to head (92a31e3).
⚠️ Report is 2001 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #859   +/-   ##
========================================
  Coverage    94.79%   94.79%           
========================================
  Files           75       75           
  Lines         5590     5590           
========================================
  Hits          5299     5299           
  Misses         291      291           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vgro vgro requested a review from jacobcook1995 June 3, 2025 10:14
Copy link
Copy Markdown
Collaborator

@jacobcook1995 jacobcook1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vgro vgro merged commit 58dcd8f into develop Jun 4, 2025
16 checks passed
@vgro vgro deleted the 858-abiotic-set-initial-constants-based-on-data-and-add-references-and-units branch June 4, 2025 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Abiotic: set initial constants based on data and add references and units

3 participants