Skip to content

704 the plantsmodel is pretending to calculate evapotranspiration#860

Merged
vgro merged 4 commits intodevelopfrom
704-the-plantsmodel-is-pretending-to-calculate-evapotranspiration
May 14, 2025
Merged

704 the plantsmodel is pretending to calculate evapotranspiration#860
vgro merged 4 commits intodevelopfrom
704-the-plantsmodel-is-pretending-to-calculate-evapotranspiration

Conversation

@vgro
Copy link
Copy Markdown
Collaborator

@vgro vgro commented May 14, 2025

This PR changes the variable name evapotranspiration to transpiration. This affects plants, hydrology and abiotic model.

Fixes #704

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works
  • Relevant documentation reviewed and updated

@vgro vgro linked an issue May 14, 2025 that may be closed by this pull request
@vgro vgro requested review from davidorme and sallymatson May 14, 2025 13:08
Copy link
Copy Markdown
Collaborator

@davidorme davidorme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vgro vgro merged commit b490690 into develop May 14, 2025
16 checks passed
@vgro vgro deleted the 704-the-plantsmodel-is-pretending-to-calculate-evapotranspiration branch May 14, 2025 13:20
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.76%. Comparing base (04bcf12) to head (2aa2bdd).
Report is 11 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #860   +/-   ##
========================================
  Coverage    94.76%   94.76%           
========================================
  Files           75       75           
  Lines         5561     5562    +1     
========================================
+ Hits          5270     5271    +1     
  Misses         291      291           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The PlantsModel is pretending to calculate evapotranspiration

3 participants