831 calculation of net radiation needs to find a place

[vgro]

This PR includes the calculation of net radiation in the simple abiotic model to make sure that it is always available for the hydrology model (it is now a required variable).

Fixes #831

Type of change

• New feature (non-breaking change which adds functionality)
• Optimization (back-end change that speeds up the code)
• Bug fix (non-breaking change which fixes an issue)

Key checklist

• Make sure you've run the pre-commit checks: $ pre-commit run -a
• All tests pass: $ poetry run pytest

Further checks

• Code is commented, particularly in hard-to-understand areas
• Tests added that prove fix is effective or that feature works
• Relevant documentation reviewed and updated

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.78%. Comparing base (2aa2bdd) to head (2a9ac65).
Report is 5 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #866      +/-   ##
===========================================
+ Coverage    94.76%   94.78%   +0.02%     
===========================================
  Files           75       75              
  Lines         5562     5584      +22     
===========================================
+ Hits          5271     5293      +22     
  Misses         291      291              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[davidorme]

LGTM - I'm not convinced that the leaf_albedo constant belongs in abiotic constants, but that's part of a bigger picture issue with the constants 😱

[vgro]

LGTM - I'm not convinced that the leaf_albedo constant belongs in abiotic constants, but that's part of a bigger picture issue with the constants 😱

Agreed. There are a few plant traits that I currently have as constants in the abiotic/hydrology model which I hope will be variables at some point. I also took a note to cross-check with the plant model at some point what is duplicated, we might want to move some constants around, but like you say, this brings us back to the old constants issue...