Skip to content

Add more informative update messages#872

Merged
davidorme merged 2 commits intodevelopfrom
871-misleading-model-update-logging-with-static-models
Jun 18, 2025
Merged

Add more informative update messages#872
davidorme merged 2 commits intodevelopfrom
871-misleading-model-update-logging-with-static-models

Conversation

@davidorme
Copy link
Copy Markdown
Collaborator

Description

Following on from comments in #686, this PR:

  • Moves the logging of update calls from ve_run into BaseModel.update so it can emit logging that discriminates between the different update modes: normal, initial update of static mode and no update because of static mode.

Fixes #871(issue)

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works
  • Relevant documentation reviewed and updated

@davidorme davidorme linked an issue May 23, 2025 that may be closed by this pull request
@davidorme davidorme requested review from hrlai and jacobcook1995 May 23, 2025 08:42
Copy link
Copy Markdown
Collaborator

@jacobcook1995 jacobcook1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 23, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.96%. Comparing base (1a7666f) to head (f460536).

Files with missing lines Patch % Lines
virtual_ecosystem/core/base_model.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #872      +/-   ##
===========================================
- Coverage    93.99%   93.96%   -0.04%     
===========================================
  Files           75       75              
  Lines         5825     5828       +3     
===========================================
+ Hits          5475     5476       +1     
- Misses         350      352       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@hrlai hrlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too, thanks!

@davidorme davidorme merged commit 2c08828 into develop Jun 18, 2025
16 checks passed
@davidorme davidorme deleted the 871-misleading-model-update-logging-with-static-models branch January 9, 2026 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Misleading model update logging with static models.

4 participants