Skip to content

Added information variables used to the soil model implementation docs#884

Merged
jacobcook1995 merged 2 commits intodevelopfrom
883-soil-model-implementation-needs-to-be-populated-with-variables
Jun 4, 2025
Merged

Added information variables used to the soil model implementation docs#884
jacobcook1995 merged 2 commits intodevelopfrom
883-soil-model-implementation-needs-to-be-populated-with-variables

Conversation

@jacobcook1995
Copy link
Copy Markdown
Collaborator

Description

Basically just the title. There's a big TODO about writing docs to explain the implementation properly at some point, but that can wait.

Fixes #883

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works
  • Relevant documentation reviewed and updated

@jacobcook1995 jacobcook1995 linked an issue Jun 4, 2025 that may be closed by this pull request
@jacobcook1995 jacobcook1995 requested a review from vgro June 4, 2025 13:09
Copy link
Copy Markdown
Collaborator

@vgro vgro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.80%. Comparing base (5e3ceef) to head (d3b7028).
⚠️ Report is 1987 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #884   +/-   ##
========================================
  Coverage    94.80%   94.80%           
========================================
  Files           75       75           
  Lines         5597     5597           
========================================
  Hits          5306     5306           
  Misses         291      291           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jacobcook1995 jacobcook1995 enabled auto-merge June 4, 2025 13:22
@jacobcook1995 jacobcook1995 merged commit 9b23fa5 into develop Jun 4, 2025
16 checks passed
@jacobcook1995 jacobcook1995 deleted the 883-soil-model-implementation-needs-to-be-populated-with-variables branch June 4, 2025 13:27
@davidorme davidorme mentioned this pull request Apr 3, 2026
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Soil model implementation needs to be populated with variables

3 participants