Skip to content

890 mycorrhizal fungi should be obligate rather than able to survive via saprotrophy#893

Merged
jacobcook1995 merged 5 commits intodevelopfrom
890-mycorrhizal-fungi-should-be-obligate-rather-than-able-to-survive-via-saprotrophy
Jun 16, 2025
Merged

890 mycorrhizal fungi should be obligate rather than able to survive via saprotrophy#893
jacobcook1995 merged 5 commits intodevelopfrom
890-mycorrhizal-fungi-should-be-obligate-rather-than-able-to-survive-via-saprotrophy

Conversation

@jacobcook1995
Copy link
Copy Markdown
Collaborator

Description

This PR changes the function that calculate mycorrhizal carbon acquisition and nutrient uptake so that only plant supplied carbon is used for growth. Nitrogen and phosphorus can still be obtained from soil organic matter, but mycorrhiza will now try and obtain inorganic nutrients first.

I also altered the test parameterisation of the arbuscular mycorrhizal fungi, so that they don't produce enzymes. Down the line I need to considering preventing them from producing enzymes at all.

Fixes #890

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works
  • Relevant documentation reviewed and updated

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.97%. Comparing base (25e34d7) to head (2e02f97).
⚠️ Report is 1950 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #893      +/-   ##
===========================================
- Coverage    93.97%   93.97%   -0.01%     
===========================================
  Files           75       75              
  Lines         5813     5811       -2     
===========================================
- Hits          5463     5461       -2     
  Misses         350      350              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@vgro vgro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jacobcook1995 jacobcook1995 enabled auto-merge June 16, 2025 12:36
@jacobcook1995 jacobcook1995 merged commit 5a41889 into develop Jun 16, 2025
16 checks passed
@jacobcook1995 jacobcook1995 deleted the 890-mycorrhizal-fungi-should-be-obligate-rather-than-able-to-survive-via-saprotrophy branch June 16, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mycorrhizal fungi should be obligate, rather than able to survive via saprotrophy

3 participants