Skip to content

return mean vertical flow for all layers#930

Merged
vgro merged 3 commits intodevelopfrom
891-return-vertical-flow-as-3d-variable
Jul 7, 2025
Merged

return mean vertical flow for all layers#930
vgro merged 3 commits intodevelopfrom
891-return-vertical-flow-as-3d-variable

Conversation

@vgro
Copy link
Copy Markdown
Collaborator

@vgro vgro commented Jul 3, 2025

This PR returns mean vertical_flow for all soil layers.

Fixes #891

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works
  • Relevant documentation reviewed and updated

@vgro vgro linked an issue Jul 3, 2025 that may be closed by this pull request
@vgro vgro requested a review from jacobcook1995 July 3, 2025 15:19
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.08%. Comparing base (18686f7) to head (b68ecc9).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #930      +/-   ##
===========================================
- Coverage    94.08%   94.08%   -0.01%     
===========================================
  Files           78       78              
  Lines         6172     6171       -1     
===========================================
- Hits          5807     5806       -1     
  Misses         365      365              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@jacobcook1995 jacobcook1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vgro vgro merged commit 527a86b into develop Jul 7, 2025
16 checks passed
@vgro vgro deleted the 891-return-vertical-flow-as-3d-variable branch July 7, 2025 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

return vertical flow as 3D variable

3 participants