Theory documentation for the soil microbial community#947
Theory documentation for the soil microbial community#947jacobcook1995 merged 18 commits intodevelopfrom
Conversation
… soil theory docs
for more information, see https://pre-commit.ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #947 +/- ##
========================================
Coverage 94.31% 94.31%
========================================
Files 79 79
Lines 6576 6576
========================================
Hits 6202 6202
Misses 374 374 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…val by water in general
docs/source/virtual_ecosystem/implementation/soil_implementation.md
Outdated
Show resolved
Hide resolved
docs/source/virtual_ecosystem/implementation/soil_implementation.md
Outdated
Show resolved
Hide resolved
hrlai
left a comment
There was a problem hiding this comment.
Looks good to me overall!
Just a side note that we should have a chat about build_microbial_group sometime later for me to better understand data needs.
|
Thanks for the suggested changes, I have implemented them!
Yes I think we should discuss this when we next meet. I'll keep this PR as a draft until then, as I think our discussion probably will give pointers for how to improve these docs further. |
|
@hrlai , if it works for you I might merge this now, and make a separate issue for the documenting microbial constants issue |
|
Yeap, it looks good and time to move on! |
|
Okay, I've made an issue for the lack of default value documentation (#987). Might be worth discussing this at our next meeting |
Description
I've added the details of how the microbial community is implemented in the model to the soil theory documentation. @hrlai let me know what you think, and feel free to make edits as you see fit. The documentation for the branch associated with this pull request can be found here
I'm setting this as a draft for now as I haven't added any documentation of the microbial group or enzyme parameters, as I wasn't sure where this best fitted. (This would be something similar to how the model constants are currently documented). If you have any suggestions for where this could fit let me know!
Fixes #814
Type of change