Skip to content

Theory documentation for the soil microbial community#947

Merged
jacobcook1995 merged 18 commits intodevelopfrom
814-microbial-community-documentation
Aug 6, 2025
Merged

Theory documentation for the soil microbial community#947
jacobcook1995 merged 18 commits intodevelopfrom
814-microbial-community-documentation

Conversation

@jacobcook1995
Copy link
Copy Markdown
Collaborator

Description

I've added the details of how the microbial community is implemented in the model to the soil theory documentation. @hrlai let me know what you think, and feel free to make edits as you see fit. The documentation for the branch associated with this pull request can be found here

I'm setting this as a draft for now as I haven't added any documentation of the microbial group or enzyme parameters, as I wasn't sure where this best fitted. (This would be something similar to how the model constants are currently documented). If you have any suggestions for where this could fit let me know!

Fixes #814

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)
  • Documentation improvement

@jacobcook1995 jacobcook1995 linked an issue Jul 14, 2025 that may be closed by this pull request
@jacobcook1995 jacobcook1995 requested a review from hrlai July 14, 2025 08:17
@jacobcook1995 jacobcook1995 self-assigned this Jul 14, 2025
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.31%. Comparing base (0861c95) to head (399c54c).
⚠️ Report is 1452 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #947   +/-   ##
========================================
  Coverage    94.31%   94.31%           
========================================
  Files           79       79           
  Lines         6576     6576           
========================================
  Hits          6202     6202           
  Misses         374      374           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@hrlai hrlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me overall!

Just a side note that we should have a chat about build_microbial_group sometime later for me to better understand data needs.

@jacobcook1995
Copy link
Copy Markdown
Collaborator Author

Thanks for the suggested changes, I have implemented them!

Just a side note that we should have a chat about build_microbial_group sometime later for me to better understand data needs.

Yes I think we should discuss this when we next meet. I'll keep this PR as a draft until then, as I think our discussion probably will give pointers for how to improve these docs further.

@jacobcook1995
Copy link
Copy Markdown
Collaborator Author

@hrlai , if it works for you I might merge this now, and make a separate issue for the documenting microbial constants issue

@hrlai
Copy link
Copy Markdown
Collaborator

hrlai commented Aug 6, 2025

Yeap, it looks good and time to move on!

@jacobcook1995 jacobcook1995 marked this pull request as ready for review August 6, 2025 09:56
@jacobcook1995
Copy link
Copy Markdown
Collaborator Author

Okay, I've made an issue for the lack of default value documentation (#987). Might be worth discussing this at our next meeting

@jacobcook1995 jacobcook1995 merged commit 3f830d4 into develop Aug 6, 2025
13 checks passed
@jacobcook1995 jacobcook1995 deleted the 814-microbial-community-documentation branch August 6, 2025 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Microbial community documentation

3 participants