Conversation
…100-we-need-to-include-some-form-of-advectionoutlet
…100-we-need-to-include-some-form-of-advectionoutlet
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #957 +/- ##
===========================================
+ Coverage 94.24% 94.27% +0.03%
===========================================
Files 79 79
Lines 6477 6511 +34
===========================================
+ Hits 6104 6138 +34
Misses 373 373 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jacobcook1995
approved these changes
Jul 21, 2025
Collaborator
jacobcook1995
left a comment
There was a problem hiding this comment.
LGTM (with the obvious caveat that I don't understand the underlying science that well)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds vertical mixing of water below the canopy and ventilation above the canopy so water can leave the system. The unit tests create nice vertical humidity profiles, however, the integrated function still returns 100% humidity. I think this has to do with the time interval and the input values and will likely become more realistic when we do the calibration. Any insight are welcome.
I also did a bit of a tidy in the test files, can be skipped.
Fixes #782
Type of change
Key checklist
pre-commitchecks:$ pre-commit run -a$ poetry run pytestFurther checks