Skip to content

967 reactivate aerodynamic resistance calculation#970

Merged
vgro merged 7 commits intodevelopfrom
967-reactivate-aerodynamic-resistance-calculation
Jul 24, 2025
Merged

967 reactivate aerodynamic resistance calculation#970
vgro merged 7 commits intodevelopfrom
967-reactivate-aerodynamic-resistance-calculation

Conversation

@vgro
Copy link
Copy Markdown
Collaborator

@vgro vgro commented Jul 24, 2025

This PR reactivates the functions for aerodynamic_resistance and friction_velocity. These used to be constants because there was a bug that was hard to identify with other pieces still largely missing. Now resolved. I also moved the function to wind.py from energy_balance.py and updated the docs.

Fixes #967

Type of change

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist

  • Make sure you've run the pre-commit checks: $ pre-commit run -a
  • All tests pass: $ poetry run pytest

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works
  • Relevant documentation reviewed and updated

@vgro vgro linked an issue Jul 24, 2025 that may be closed by this pull request
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.21%. Comparing base (7dc92cf) to head (99ff36f).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #970      +/-   ##
===========================================
- Coverage    94.22%   94.21%   -0.02%     
===========================================
  Files           79       79              
  Lines         6563     6564       +1     
===========================================
  Hits          6184     6184              
- Misses         379      380       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vgro vgro requested a review from jacobcook1995 July 24, 2025 10:15
Copy link
Copy Markdown
Collaborator

@jacobcook1995 jacobcook1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (just a couple of minor queries)

@vgro vgro merged commit ea7ac16 into develop Jul 24, 2025
16 checks passed
@vgro vgro deleted the 967-reactivate-aerodynamic-resistance-calculation branch July 24, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

reactivate aerodynamic resistance calculation

3 participants