Conversation
…ber-of-canopy-layers
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #976 +/- ##
===========================================
+ Coverage 94.21% 94.23% +0.02%
===========================================
Files 79 79
Lines 6564 6589 +25
===========================================
+ Hits 6184 6209 +25
Misses 380 380 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the tests in the abiotic folder to run with a varying number of canopy layers. This required introducing a few extra functions that deal with NaN and fixing how the layer thickness is calculated. I also fixed a sign error in the temperature updated.
You will see some slightly convoluted masking in some of the tests, that is to check that the true values are not NaN.
I haven't introduced a non-vegetated grid cell, this will be addressed in #975 .
Fixes #973
Type of change
Key checklist
pre-commitchecks:$ pre-commit run -a$ poetry run pytestFurther checks