About : Remove misleading info#785
Merged
JF002 merged 1 commit intoInfiniTimeOrg:developfrom Nov 28, 2021
SteveAmor:patch-3
Merged
About : Remove misleading info#785JF002 merged 1 commit intoInfiniTimeOrg:developfrom SteveAmor:patch-3
JF002 merged 1 commit intoInfiniTimeOrg:developfrom
SteveAmor:patch-3
Conversation
Removed Steps which is hard coded to display 0. Could be misleading and is using up memory.
Member
|
Yeah, this should be removed like in this PR or actually updated to display the appropriate info. In reality Is this even needed on the about screen or is it an artifact of a previous iteration of infinitime? |
Riksu9000
approved these changes
Nov 6, 2021
Contributor
Riksu9000
left a comment
Riksu9000
left a comment
There was a problem hiding this comment.
About is a place for verbose information that might not exist elsewhere. The step count can be seen in the steps app, so it's not necessary here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed Steps which is hard coded to display 0.
Could be misleading and is using up memory.