This is the minimum required code to get the ports to tie from the di…#208
Merged
ElanHasson merged 3 commits intoInfinityFlowApp:mainfrom Sep 26, 2025
Merged
This is the minimum required code to get the ports to tie from the di…#208ElanHasson merged 3 commits intoInfinityFlowApp:mainfrom
ElanHasson merged 3 commits intoInfinityFlowApp:mainfrom
Conversation
…splay to the resource. If you try to overwrite the original line 5 var temporal with ports, the dashboard has them but they do not connect.
Contributor
|
@Omnideth thank you for the PR! |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
ElanHasson
reviewed
Sep 24, 2025
| if (args.HttpPort is not null) | ||
| { | ||
| resourceBuilder.WithHttpEndpoint(name: "http", port: args.HttpPort, targetPort: 7234); // Internal port is always 7234 | ||
| resourceBuilder.WithHttpEndpoint(name: "http", port: args.HttpPort, targetPort: args.HttpPort); // Internal port is always 7234 |
There was a problem hiding this comment.
Bug: Incorrect Port Mapping for Temporal Server
The targetPort for Temporal server endpoints is incorrectly set to external args.Port values instead of the fixed internal container ports (e.g., 7233 for server). This breaks container port mapping, preventing connections, and contradicts the inline comments that state these internal ports are always fixed.
ElanHasson
approved these changes
Sep 26, 2025
Contributor
|
Fixes #208 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…splay to the resource.
If you try to overwrite the original line 5 var temporal with ports, the dashboard has them but they do not connect.