Add WithDataVolume/WithDataBindMount and fix flaky integration tests#290
Merged
ElanHasson merged 5 commits intomainfrom Mar 7, 2026
Merged
Add WithDataVolume/WithDataBindMount and fix flaky integration tests#290ElanHasson merged 5 commits intomainfrom
ElanHasson merged 5 commits intomainfrom
Conversation
…nce (#258) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Use non-proxied server endpoint instead of separate grpc-direct endpoint.
Add [Collection("Integration")] to prevent parallel port 7233 conflicts.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ElanHasson
commented
Mar 7, 2026
src/InfinityFlow.Aspire.Temporal/TemporalServerResourceExtensions.cs
Outdated
Show resolved
Hide resolved
ElanHasson
commented
Mar 7, 2026
src/InfinityFlow.Aspire.Temporal/TemporalServerResourceExtensions.cs
Outdated
Show resolved
Hide resolved
…ndMount Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…tory Instead of overriding the db filename, respect any existing TemporalDbFileNameAnnotation and mount the volume to its directory. Only set the default /data/temporal.db if no annotation exists. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WithDataVolume()andWithDataBindMount()convenience methods for persisting Temporal's SQLite database across container restarts, following the Aspire convention (Postgres, Valkey, NATS pattern)isProxied: falseendpoints and serializing integration test classes with[Collection("Integration")]Closes #258
Test plan
WithDataVolumeandWithDataBindMount(annotations + mount types)Changes
src/.../TemporalServerResourceExtensions.csWithDataVolume()andWithDataBindMount()tests/.../TemporalFluentApiTests.cstests/.../TemporalIntegrationTests.cs[Collection]tests/.../TemporalClientIntegrationTests.cs[Collection]sample/AppHost/Program.cs🤖 Generated with Claude Code