-
Notifications
You must be signed in to change notification settings - Fork 33
[CP-446] created v2 client for exchange v2 endpoints #382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CP-446] created v2 client for exchange v2 endpoints #382
Conversation
…ge v2 endpoints. The original Composer and AsyncClient are still supported. Created an IndexerClient for all indexer endpoints
… Exchange module V2 queries and types. Updated examples and tests.
|
Important Review skippedMore than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review. 93 files out of 300 files are above the max files limit of 200. You can disable this status message by setting the ✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new v2 AsyncClient and Composer for the exchange module, refactors existing clients to use the IndexerClient, and updates examples, tests, and proto definitions to support human‐readable market values.
- Updated all example scripts to import AsyncClient from the new async_client_v2 module.
- Refactored message constructors and composer methods to use the new v2 naming conventions.
- Updated dependency versions and documentation to reflect v2 features.
Reviewed Changes
Copilot reviewed 349 out of 349 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| examples/chain_client/bank/query/1_BankBalance.py | Updated AsyncClient import to v2 |
| examples/chain_client/bank/query/10_SendEnabled.py | Updated AsyncClient import to v2 |
| examples/chain_client/bank/1_MsgSend.py | Updated AsyncClient import and modified msg_send amount |
| examples/chain_client/authz/query/1_Grants.py | Updated AsyncClient import to v2 |
| examples/chain_client/authz/3_MsgRevoke.py | Updated AsyncClient import and message renaming |
| examples/chain_client/authz/2_MsgExec.py | Updated AsyncClient import and message renaming |
| examples/chain_client/authz/1_MsgGrant.py | Updated AsyncClient import and message renaming |
| examples/chain_client/auth/query/1_Account.py | Updated AsyncClient import to v2 |
| examples/chain_client/auction/1_MsgBid.py | Updated AsyncClient import and message renaming |
| examples/chain_client/9_PaginatedRequestExample.py | Updated AsyncClient import to v2 |
| examples/chain_client/7_ChainStream.py | Updated chain stream filter and listener methods for v2 |
| examples/chain_client/6_MessageBroadcasterWithGranteeAccountWithoutSimulation.py | Updated AsyncClient import and message renaming |
| examples/chain_client/5_MessageBroadcasterWithoutSimulation.py | Updated AsyncClient import and message naming (review potential double reference issue) |
| examples/chain_client/4_MessageBroadcasterWithGranteeAccount.py | Updated AsyncClient import and message renaming |
| examples/chain_client/3_MessageBroadcaster.py | Updated AsyncClient import and message renaming |
| examples/chain_client/1_LocalOrderHash.py | Updated AsyncClient import and order creation method names |
| buf.gen.yaml | Updated dependency version tags |
| README.md | Added documentation for choosing between Exchange V1 and V2 clients |
| Makefile | Updated clone branch for the indexer dependency |
| CHANGELOG.md | Documented the new v2 features and removal of deprecated methods |
Comments suppressed due to low confidence (1)
README.md:102
- The new documentation refers to the import as 'injective.async_client_v2' while the code examples use 'pyinjective.async_client_v2'. Ensure that the module naming is consistent across the repository.
from injective.async_client_v2 import AsyncClient
Solves CP-446