Skip to content

Conversation

@antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented May 8, 2024

The PR proposes to implement dpnp.nancumprod() through existing call of dpnp.cumprod function.
All the relating tests are unmuted now.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this May 8, 2024
@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2024

View rendered docs @ https://intelpython.github.io/dpnp/pull//index.html

Base automatically changed from implement-cumprod to master May 9, 2024 12:42
Copy link
Contributor

@vtavana vtavana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @antonwolfy!

@antonwolfy antonwolfy merged commit 5d94ca8 into master May 10, 2024
@antonwolfy antonwolfy deleted the implement-nancumprod branch May 10, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants