Fixes the caching of DpctlSyclQueue instances. #1047
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Enables using the queue keyword for dpnp array constructors.
- Uses the DpctlSyclQueueRef for memory allocations and remove
using a filter string to first create a queue.
- Unit tests.
- Removes a queue copy during NRTExternalAllocator as the
ownership of the passed in queue belongs to the
NRTExternalAllocator and the extra copy introduced a memory
leak. It is the caller's responsibility to do any queue
copy if needed.
- Reverts all superfluous naming changes to reduce the diff.
- Fixes few docstrings that needed to be updated.
Refactored tests/core/types/USMNdArray/test_array_creation_errors.py, since we got rid of filter_string and USMNdArray allocates int64 by default, not float64, like they do in numpy and dpnp Need to use dpctl._sycl_queue_manager
Revert to original coverage.yml
chudur-budur
force-pushed
the
feature/support_sycl_queue_in_array_ctors
branch
from
a39bc5d to
43470c7
Compare
Contributor
|
The modifications are already merged in #1032 and it's working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have you provided a meaningful PR description?
Changes the
keyproperty of theDpctlSyclQueueclass ensuring that differentdpctl.SyclQueueobjects are treated as separate instances of theDpctlSyclQueuetype.Have you added a test, reproducer or referred to an issue with a reproducer?
Have you tested your changes locally for CPU and GPU devices?
Have you made sure that new changes do not introduce compiler warnings?
If this PR is a work in progress, are you filing the PR as a draft?