Skip to content

fix: update Itanium CXX ABI Mangler reference #1080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
diptorupd merged 1 commit into from
Jun 18, 2023
Merged

fix: update Itanium CXX ABI Mangler reference #1080

diptorupd merged 1 commit into from
Jun 18, 2023

Conversation

@emmanuel-ferdman
Copy link
Contributor

@emmanuel-ferdman emmanuel-ferdman commented Jun 18, 2023 •
edited
Loading

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

This PR resolves a broken hyperlink found in the core/itanium_mangler.py file. This is because the C++ ABI repository
moved from MentorEmbedded/cxx-abi to itanium-cxx-abi/cxx-abi (see README file of MentorEmbedded/cxx-abi). You can find this broken hyperlink in the docs here.

@intel-python-devops
Copy link

intel-python-devops commented Jun 18, 2023

Can one of the admins verify this patch?

diptorupd
diptorupd approved these changes Jun 18, 2023
View reviewed changes
Copy link
Contributor

@diptorupd diptorupd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@diptorupd diptorupd merged commit 2e198fa into IntelPython:main Jun 18, 2023
github-actions bot added a commit that referenced this pull request Jun 18, 2023
@github-actions
Merge pull request #1080 from emmanuel-ferdman/wip
99a97ab 
fix: update Itanium CXX ABI Mangler reference 2e198fa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@diptorupd diptorupd diptorupd approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@emmanuel-ferdman @intel-python-devops @diptorupd