Merged
Conversation
diptorupd
force-pushed
the
feature/improved_sycl_queue_support
branch
from
fd04d93 to
d7c2405
Compare
added 2 commits
July 1, 2023 01:36
- Creates a new data model DpnpNdArrayModel to represent
DpnpNdArray type objects natively.
The data model differs from numba's ArrayModel by having
an extra member to store a sycl::queue pointer.
- Introduces a _usmarraystruct.h header to define the
C struct for the DpnpNdArrayModel.
- Renames numba_dpex.core.datamodel.models.ArrayModel to
USMArrayModel.
- Updates kernel launcher and parfor lowering functions to
account for the new data model.
diptorupd
force-pushed
the
feature/improved_sycl_queue_support
branch
from
5fd5074 to
7b9cccd
Compare
- Updates the *_like overloads to extract the
sycl_queue for the input array. It was not possible
previously as the sycl_queue attribute was not present.
- Update unit tests.
- Add new unit tests.
diptorupd
force-pushed
the
feature/improved_sycl_queue_support
branch
from
7b9cccd to
7a5a317
Compare
Contributor
Author
|
@chudur-budur The changes are good to go and ready for review. |
Contributor
Author
|
ping @chudur-budur |
chudur-budur
suggested changes
Jul 6, 2023
Contributor
chudur-budur
left a comment
chudur-budur
left a comment
There was a problem hiding this comment.
Looks good but there are some issues and questions that I think need to be addressed before merge.
numba_dpex/dpnp_iface/_intrinsic.py
Outdated
| builder, | ||
| sig, | ||
| args, | ||
| sycl_queue_arg_pos=sycl_queue_arg_pos, |
Contributor
There was a problem hiding this comment.
Can we just declare these two values like a constant at the top of the file and use it everywhere?
Contributor
Author
There was a problem hiding this comment.
Generally, I will like to avoid global variables. I also wish to find a way to not have to do the hard coded variables, just could not find a way out of properly using keyword args.
added 2 commits
July 6, 2023 23:31
- Addresses the review comment to pass required arguments to
_get_queue_ref explicitly.
github-actions bot
added a commit
that referenced
this pull request
Jul 11, 2023
…_support Feature/improved sycl queue support 81af300
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an extra member to the data model used for a DpnpNdArray typed object that will store a
DpctlSyclQueueRefpointer. The change makes it possible to extract the sycl queue pointer used to allocate a dpnp.ndarray from the dpnp.ndarray native representation inside numba-dpex.With the change all dpnp
*_likeconstructor overloads can now use the exact same queue object from the passed in dpnp.ndarray argument if needed.