Feature/add python object createion for unboxing sycl event and queue #1193

ZzEeKkAa · 2023-10-27T17:58:56Z

Add python object creation if dpctl.SyclEvent or dpctl.SyclQueue where allocated in dpjit function.

Closes: #1181
Closes: #1182
Closes: #1183

Have you provided a meaningful PR description?
Have you added a test, reproducer or referred to an issue with a reproducer?
Have you tested your changes locally for CPU and GPU devices?
Have you made sure that new changes do not introduce compiler warnings?
If this PR is a work in progress, are you filing the PR as a draft?

numba_dpex/dpnp_iface/_intrinsic.py

diptorupd · 2023-10-31T21:28:33Z

numba_dpex/tests/dpjit_tests/dpnp/test_dpnp_empty.py

+    b = func(a)
+
+    assert b is not None
+    assert b.sycl_queue is not None


we should also be able to assert b.sycl_queue == a.sycl_queue?

It will fail then. I don't know how to add just one assert as expected failure

Why will it fail? The __eq__ of the dpctl.SyclQueue class just calls the DPCTLQueue_Equal function that should evaluate to true if the qref pointers point to the same underlying sycl::queue object.

We must be more specific. It suppose to be same object. Marked test as XFAIL.

numba_dpex/tests/dpjit_tests/dpnp/test_dpnp_empty.py

numba_dpex/tests/core/types/DpctlSyclQueue/test_box.py

diptorupd · 2023-10-31T21:31:02Z

numba_dpex/tests/core/types/DpctlSyclQueue/test_box.py

+
+    assert q is not None
+    assert isinstance(q, SyclQueue)
+    assert id(q) == id(arr.sycl_queue)  # this must work after dpjit fix


Only the last assert is xfail right? The other asserts should pass?

Yes, is there a way to achieve it?

You will have to write two separate test cases.

I've been thinking about what test should actually check and updated tests a little bit. So this one is always pass, and another one is failing. Thx

numba_dpex/dpnp_iface/arrayobj.py

numba_dpex/dpnp_iface/_intrinsic.py

diptorupd · 2023-11-01T18:30:56Z

numba_dpex/tests/dpjit_tests/dpnp/test_dpnp_empty.py

+    a = dpnp.empty(10)
+    b = func(a)
+
+    assert a.sycl_queue == b.sycl_queue


diptorupd

Thank you!

…reateion_for_unboxing_sycl_event_and_queue Feature/add python object createion for unboxing sycl event and queue ac05c1a

ZzEeKkAa self-assigned this Oct 27, 2023

ZzEeKkAa requested review from chudur-budur and diptorupd as code owners October 27, 2023 17:58

diptorupd reviewed Oct 30, 2023

View reviewed changes

numba_dpex/dpnp_iface/_intrinsic.py Outdated Show resolved Hide resolved

diptorupd reviewed Oct 30, 2023

View reviewed changes

numba_dpex/dpnp_iface/_intrinsic.py Outdated Show resolved Hide resolved

diptorupd reviewed Oct 30, 2023

View reviewed changes

numba_dpex/dpnp_iface/_intrinsic.py Show resolved Hide resolved

diptorupd reviewed Oct 30, 2023

View reviewed changes

numba_dpex/dpnp_iface/_intrinsic.py Show resolved Hide resolved

ZzEeKkAa force-pushed the feature/add_python_object_createion_for_unboxing_sycl_event_and_queue branch from 91e6a57 to cccf948 Compare October 30, 2023 19:25

ZzEeKkAa added 5 commits October 30, 2023 19:00

Pin python version for pre-commit

08bd841

Add python object creation for unboxing SyclEvent

70ebc88

Add python object creation for unboxing SyclQueue

96dea84

Fix queue_ref attribute reference

50c45de

Add parent to SyclQueue struct

cbbe5e0

ZzEeKkAa force-pushed the feature/add_python_object_createion_for_unboxing_sycl_event_and_queue branch from cccf948 to 45c189d Compare October 30, 2023 23:01

ZzEeKkAa enabled auto-merge October 31, 2023 16:14

diptorupd reviewed Oct 31, 2023

View reviewed changes

numba_dpex/tests/dpjit_tests/dpnp/test_dpnp_empty.py Outdated Show resolved Hide resolved

diptorupd reviewed Oct 31, 2023

View reviewed changes

numba_dpex/tests/core/types/DpctlSyclQueue/test_box.py Outdated Show resolved Hide resolved

diptorupd reviewed Oct 31, 2023

View reviewed changes

numba_dpex/dpnp_iface/arrayobj.py Show resolved Hide resolved

diptorupd reviewed Oct 31, 2023

View reviewed changes

numba_dpex/dpnp_iface/_intrinsic.py Outdated Show resolved Hide resolved

ZzEeKkAa disabled auto-merge October 31, 2023 21:35

ZzEeKkAa added 2 commits November 1, 2023 12:56

Overload dpnp array's sycl_queue attribute

ab22e21

Add test for SyclQueue boxing without parent

863c7ad

ZzEeKkAa force-pushed the feature/add_python_object_createion_for_unboxing_sycl_event_and_queue branch from 45c189d to 159c698 Compare November 1, 2023 16:56

ZzEeKkAa added 3 commits November 1, 2023 14:12

Add test for dpnp.empty() with dpjit queue arg

9b5b38f

Fail on xpass

ad3cb29

Remove xfail from parfors test_unary_ops

f46e145

ZzEeKkAa force-pushed the feature/add_python_object_createion_for_unboxing_sycl_event_and_queue branch from 57885a0 to f46e145 Compare November 1, 2023 18:12

diptorupd reviewed Nov 1, 2023

View reviewed changes

numba_dpex/tests/dpjit_tests/dpnp/test_dpnp_empty.py

a = dpnp.empty(10)

b = func(a)

assert a.sycl_queue == b.sycl_queue

Copy link

Contributor

diptorupd Nov 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

diptorupd approved these changes Nov 1, 2023

View reviewed changes

diptorupd merged commit ac05c1a into main Nov 1, 2023

diptorupd deleted the feature/add_python_object_createion_for_unboxing_sycl_event_and_queue branch November 1, 2023 18:32

github-actions bot added a commit that referenced this pull request Nov 1, 2023

Merge pull request #1193 from IntelPython/feature/add_python_object_c…

808b964

…reateion_for_unboxing_sycl_event_and_queue Feature/add python object createion for unboxing sycl event and queue ac05c1a

Feature/add python object createion for unboxing sycl event and queue #1193

Feature/add python object createion for unboxing sycl event and queue #1193

Uh oh!

Conversation

ZzEeKkAa commented Oct 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

diptorupd left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ZzEeKkAa commented Oct 27, 2023 •

edited

Loading