Skip to content

Create dpnp specific ufunc db #1267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ZzEeKkAa merged 2 commits into from
Jan 5, 2024
Merged

Create dpnp specific ufunc db #1267

ZzEeKkAa merged 2 commits into from
Jan 5, 2024

Conversation

@ZzEeKkAa
Copy link
Contributor

@ZzEeKkAa ZzEeKkAa commented Jan 4, 2024 •
edited
Loading

Add tests to ensure that numba.njit works with numpy after importing numba_dpex. Aka lazy testing if we break numba's default behavior.

Fixes: #1010

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@ZzEeKkAa ZzEeKkAa changed the base branch from main to feature/switch_to_dpex_target_context January 4, 2024 21:41
Base automatically changed from feature/switch_to_dpex_target_context to main January 4, 2024 21:45
@ZzEeKkAa ZzEeKkAa force-pushed the fix/issue_1010 branch 3 times, most recently from db76b71 to d95df65 Compare January 4, 2024 21:51
@ZzEeKkAa ZzEeKkAa self-assigned this Jan 4, 2024
@ZzEeKkAa ZzEeKkAa changed the title Fix/issue 1010 Create dpnp specific ufunc db Jan 4, 2024
@ZzEeKkAa ZzEeKkAa marked this pull request as ready for review January 4, 2024 21:53
diptorupd
diptorupd approved these changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@diptorupd diptorupd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks you! Another one bites the dust!

@ZzEeKkAa ZzEeKkAa enabled auto-merge January 4, 2024 22:02
diptorupd
diptorupd previously requested changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@diptorupd diptorupd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have some CI failures that should be investigated.

@ZzEeKkAa ZzEeKkAa requested a review from diptorupd January 4, 2024 22:20
Diptorup Deb and others added 2 commits January 5, 2024 15:47
@ZzEeKkAa
Create and use dpnp specific ufunc db
c9567f3 
Co-authored-by: Yevhenii Havrylko <yevhenii.havrylko@intel.com>
@ZzEeKkAa
Add numba integration tests
eca15ed
diptorupd
diptorupd approved these changes Jan 5, 2024
View reviewed changes
Copy link
Contributor

@diptorupd diptorupd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should revisit if we should use deepcopy when copying the numba ufunc_db so as to not have a special case for missing operators. Can be revisited after we reevaluate #178

@ZzEeKkAa ZzEeKkAa merged commit 46cfa8c into main Jan 5, 2024
@ZzEeKkAa ZzEeKkAa deleted the fix/issue_1010 branch January 5, 2024 21:26
github-actions bot added a commit that referenced this pull request Jan 5, 2024
@github-actions
Merge pull request #1267 from IntelPython/fix/issue_1010
39fbde5 
Create dpnp specific ufunc db 46cfa8c
@ZzEeKkAa ZzEeKkAa mentioned this pull request Jan 19, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chudur-budur chudur-budur Awaiting requested review from chudur-budur

1 more reviewer

@diptorupd diptorupd diptorupd approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ZzEeKkAa ZzEeKkAa

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Numba_dpex breaks numba execution

2 participants

@ZzEeKkAa @diptorupd