Refactor kernel sim for the experimental kernel#1302
Closed
chudur-budur wants to merge 16 commits intoIntelPython:mainfrom
Closed
Refactor kernel sim for the experimental kernel#1302chudur-budur wants to merge 16 commits intoIntelPython:mainfrom
chudur-budur wants to merge 16 commits intoIntelPython:mainfrom
Conversation
chudur-budur
force-pushed
the
refactor/kernel-sim
branch
2 times, most recently
from
b07bee4 to
d546001
Compare
chudur-budur
force-pushed
the
refactor/kernel-sim
branch
3 times, most recently
from
1069a87 to
3733e1f
Compare
Expose FakeKernel functions as @staticmethod
chudur-budur
force-pushed
the
refactor/kernel-sim
branch
2 times, most recently
from
777194e to
4644569
Compare
Contributor
Author
|
@diptorupd I think it's good to go. |
chudur-budur
force-pushed
the
refactor/kernel-sim
branch
2 times, most recently
from
4ebdfe5 to
c280ec7
Compare
Adding docstrings Pylint fixes Fix pylint issues More pylint fixes
chudur-budur
force-pushed
the
refactor/kernel-sim
branch
from
c280ec7 to
1509535
Compare
Contributor
|
@chudur-budur Thank you for the PR. However, the approach in your simulator implementation does not work with the I have added kernel executors in #1326 for Range and NdRange kernels that serve the purpose of executing the pure Python mock kernels. The kernel launcher does not yet support barriers, I will perhaps add that at a later date borrowing ideas from @Hardcode84's use of the I am closing this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This WIP refactors
kernel-simfor the new experimental kernel. This is based on #992 and will supercede #992.