Skip to content

update wheel tag with pep600 #1452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ZzEeKkAa merged 2 commits into from
May 7, 2024
Merged

update wheel tag with pep600 #1452

ZzEeKkAa merged 2 commits into from
May 7, 2024

Conversation

@ekomarova
Copy link
Contributor

@ekomarova ekomarova commented May 7, 2024 •
edited
Loading

This PR is designed to fix the problem described here: SAT-6873. I did some experiments and found out that using pep600 wheel tag prevents the wheel from being installed on non-supported platforms

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@ekomarova ekomarova requested review from ZzEeKkAa and diptorupd May 7, 2024 12:15
@coveralls
Copy link
Collaborator

coveralls commented May 7, 2024 •
edited
Loading

Coverage Status

coverage: 86.494%. remained the same
when pulling 9a5bebd on ekomarova/update_wheel_tag
into ab500b6 on main.

@ekomarova
Copy link
Contributor Author

ekomarova commented May 7, 2024 •
edited
Loading

The validation issue is not related to these changes

@ZzEeKkAa ZzEeKkAa force-pushed the ekomarova/update_wheel_tag branch from c0dfdc1 to 9a5bebd Compare May 7, 2024 18:04
ZzEeKkAa
ZzEeKkAa approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@ZzEeKkAa ZzEeKkAa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I've updated the PR to use glibc version from system, not like a magic constant

@ZzEeKkAa ZzEeKkAa enabled auto-merge May 7, 2024 18:07
@ZzEeKkAa ZzEeKkAa merged commit e36c979 into main May 7, 2024
@ZzEeKkAa ZzEeKkAa deleted the ekomarova/update_wheel_tag branch May 7, 2024 18:37
github-actions bot added a commit that referenced this pull request May 7, 2024
@github-actions
Merge pull request #1452 from IntelPython/ekomarova/update_wheel_tag
2d0eff5 
update wheel tag with pep600 e36c979
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oleksandr-pavlyk oleksandr-pavlyk Awaiting requested review from oleksandr-pavlyk

2 more reviewers

@diptorupd diptorupd diptorupd approved these changes

@ZzEeKkAa ZzEeKkAa ZzEeKkAa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ekomarova @coveralls @diptorupd @ZzEeKkAa