Fixes to checking validity of a range. #876
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removes superfluous copy inside JitKernel.__getitem__
- Improves the JitKernel._check_range and JitKernel._check_ranges
methods. We now check if a range is empty and if a well-formed
global range was provided.
- Minor fixes to error messages (typos, etc.)
- Add missing docstrings to numba_dpex.core.exceptions classes.
mingjie-intel
approved these changes
Jan 19, 2023
github-actions bot
added a commit
that referenced
this pull request
Jan 19, 2023
Fixes to checking validity of a range. 9809c95
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
methods. We now check if a range is empty and if a well-formed
global range was provided.