feature/strip encoder parameter

[olivervogel]

No description provided.

[olivervogel]

I added the option to the global configuration and set the default values on the encoders to null which will default to the value of the global configuration.

$manager = ImageManager::withDriver($driver, strip: true); // set global default for all operations
$result = $manager->read('exif.jpg')->toJpeg(); // uses global default
$result = $manager->read('exif.jpg')->toJpeg(strip: false); // overrides global default
$result = $manager->read('exif.jpg')->toJpeg(strip: true); // overrides global default

I'm also thinking about renaming the option from strip to stripMeta? I'm not a native English speaker but I think strip is very arbitrary? What do you think? @deluxetom

[deluxetom]

Looks great, I like the global option, it makes it much easier.

As for GD, I agree, it just strips the exif metadata when encoding. I don't really like the method to create a new GD object and encoding to jpeg to remove it though as quality 100 for jpeg isn't lossless.

I would probably just disable the StripModifier for GD and throw an exception that the GD driver already strips metadata when encoding.

[deluxetom]

I'm also thinking about renaming the option from strip to stripMeta? I'm not a native English speaker but I think strip is very arbitrary? What do you think? @deluxetom

I think strip is fine, I would just add a PHPDoc to add that it strips exif metadata. I'm not a native English speaker myself

[deluxetom]

perfect, once thats merged, I'll fix image-driver-vips to add that modifier

[olivervogel]

perfect, once thats merged, I'll fix image-driver-vips to add that modifier

Cool. You can use intervention image ^3.11 for that.