Conversation
rosiel
approved these changes
Aug 7, 2023
Member
|
Passed smoke test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub Issue: #101
What does this Pull Request do?
Adds
^3as a valid version for professional-wiki/edtf.How should this be tested?
composer require islandora/controlled_access_terms:"dev-issue-101 as 2.2.3" professional-wiki/edtf:^3. Composer should be happy with this.Alternatively, if you don't want to go through and set up all the year search index stuff, you could save the test-edtf-3.php.txt (a trimmed down version of the year index code) to your web directory, rename it to remove '.txt' which I had to add to appease GitHub, and run
drush scr test-edtf-3.php -- '2017/2022'(or substitute '2017/2022' with any other valid EDTF). Look for a list of integers matching the years covered by the EDTF with no errors appearing.Interested parties
@Islandora/committers