Use drupal namespace instead of islandora.

[rosiel]

GitHub Issue: Islandora/documentation#2270

• Other Relevant Links (Google Groups discussion, related pull requests,
  Release pull requests, etc.)

https://groups.google.com/g/islandora/c/brFsDlPRwrI/m/JcgM29OwAAAJ

What does this Pull Request do?

Changes the name of the module.

What's new?

• changes islandora/controlled_access_terms to drupal/controlled_access_terms

How should this be tested?

• On a properly set-up Islandora site, this should be transparent. you should already require drupal/controlled_access_terms. Also you should be getting it from drupal.org.
• It is the desired state that when you composer require drupal/controlled_access_terms, you should get it from drupal.org (because you have the drupal composer repository:

   "repositories": [
        {
            "type": "composer",
            "url": "https://packages.drupal.org/8"
        },
    ]

This already happens but is due to our syncing to Drupal.org.

• If you do need to download this code from GitHub (for testing PRs) then add a repository to your composer.json that points to this repo, and position it above the packages.drupal.org/8 one.
• The only tangible result of this PR is that composer require islandora/controlled_access_terms should stop working, which can't be tested until merge.
• Tests still need to pass. I edited the namespace there too.

Additional Notes:

Any additional information that you think would be helpful when reviewing this
PR.

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora/committers

[rosiel]

Reminder to use composer why on all your sites to make sure you don't have dependencies that require the old namespace.
composer why islandora/controlled_access_terms

[aOelschlager]

Approved in tech meeting.