Skip to content

minor improvements#69

Merged
SamuelBrucksch merged 1 commit intomasterfrom
chore/housekeeping
Apr 16, 2026
Merged

minor improvements#69
SamuelBrucksch merged 1 commit intomasterfrom
chore/housekeeping

Conversation

@g4rb4g3
Copy link
Copy Markdown
Contributor

@g4rb4g3 g4rb4g3 commented Apr 16, 2026

This PR addresses a few minor issues:

  • user-supplied fontScale was always ignored
  • maxMemory().toInt() might overflow
  • missleading errors on HybridMapTemplate
  • Debouncer creating new scope instance on each submit call

@g4rb4g3 g4rb4g3 marked this pull request as ready for review April 16, 2026 13:53
@g4rb4g3 g4rb4g3 requested a review from SamuelBrucksch April 16, 2026 13:54
@github-actions
Copy link
Copy Markdown
Contributor

No significant issues found.

: 'transparent';

const fontScale = (button.image.fontScale ?? Platform.OS === 'android') ? 1.0 : 0.65;
const fontScale = button.image.fontScale ?? (Platform.OS === 'android' ? 1.0 : 0.65);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😆

@SamuelBrucksch SamuelBrucksch removed their assignment Apr 16, 2026
@SamuelBrucksch SamuelBrucksch merged commit 9719914 into master Apr 16, 2026
4 checks passed
@SamuelBrucksch SamuelBrucksch deleted the chore/housekeeping branch April 16, 2026 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants