Update version of eth-utils to match requirements#399
Merged
arjanz merged 1 commit intoJAMdotTech:masterfrom Jul 15, 2024
Merged
Update version of eth-utils to match requirements#399arjanz merged 1 commit intoJAMdotTech:masterfrom
arjanz merged 1 commit intoJAMdotTech:masterfrom
Conversation
In JAMdotTech#388 I edited the requirements.txt and didn't notice that the requirements are hardcoded in the setup.py. This PR is to have the same version in both
Contributor
Yes this would indeed be the way to go, I'll have a look when I'm back in the office |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #388 I edited the requirements.txt and didn't notice that the requirements are hardcoded in the setup.py. This PR is to have the same version in both
https://github.com/polkascan/py-substrate-interface/blob/43ad00cca215dfafd4607be6440aecd198ee6089/requirements.txt#L10
Would you consider using
pyproject.tomlinstead of setup.py to avoid this errors? Also setup.py is being deprecated afaik.