feat(config): add refresh interval for periodic prompt updates #6938

sanki92 · 2025-11-02T10:09:52Z

Prerequisites

I have read and understood the contributing guide.
The commit message follows the conventional commits guidelines.
Tests for the changes have been added (for bug fixes / features).
Docs have been added/updated (for bug fixes / features).

Description

Issue

Problem

Prompt only refreshes when executing commands. Users had to press Enter repeatedly to see updated git status, time, battery, and other dynamic segments.

Solution

Added refresh_interval config option (in milliseconds) to automatically refresh the prompt on a timer. Implemented using native shell mechanisms for PowerShell, Zsh, Bash, and Fish.

Changes Made

Added RefreshInterval field to Config struct and feature detection logic
Implemented timer-based refresh for PowerShell (using System.Timers.Timer)
Implemented timer-based refresh for Zsh (using TMOUT and TRAPALRM)
Implemented timer-based refresh for Bash (using background process with SIGWINCH)
Implemented timer-based refresh for Fish (using background process with SIGUSR1)
Added TestRefreshIntervalFeature and updated all shell feature tests

Testing

✅ All existing tests pass - no breaking changes
✅ New unit test validates feature detection for all shells
✅ Shell feature tests updated to include RefreshInterval

Usage Example

{
  "refresh_interval": 5000,
  "blocks": [...]
}

Prompt now refreshes every 5 seconds, automatically updating git status, time, and all dynamic segments without pressing Enter.

Supported shells: PowerShell, Zsh, Bash, Fish
Implementation: Non-blocking, uses native shell timers, opt-in only, proper resource cleanup

Copilot

Pull Request Overview

This PR adds a refresh interval feature that allows prompts to be automatically refreshed at a configurable time interval. This enables time-based segments (like clocks) to update automatically without requiring user interaction.

Key Changes:

Added RefreshInterval feature flag to the shell features system
Implemented refresh interval functionality for PowerShell, Zsh, Bash, and Fish shells
Updated initialization code to pass refresh interval configuration to shell scripts

Reviewed Changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
src/shell/features.go	Added RefreshInterval constant to feature flags
src/config/config.go	Added RefreshInterval field and logic to enable feature for supported shells
src/shell/init.go	Updated Init and PrintInit functions to accept and pass refreshInterval parameter
src/cli/init.go	Modified to pass RefreshInterval from config to shell initialization
src/shell/pwsh.go	Added PowerShell feature mapping for RefreshInterval
src/shell/zsh.go	Added Zsh feature mapping for RefreshInterval
src/shell/bash.go	Added Bash feature mapping for RefreshInterval
src/shell/fish.go	Added Fish feature mapping for RefreshInterval
src/shell/scripts/omp.ps1	Implemented timer-based prompt refresh using System.Timers.Timer
src/shell/scripts/omp.zsh	Implemented prompt refresh using TMOUT and TRAPALRM
src/shell/scripts/omp.bash	Implemented prompt refresh using background process with SIGWINCH
src/shell/scripts/omp.fish	Implemented prompt refresh using background process with SIGUSR1
src/shell/pwsh_test.go	Updated tests to include RefreshInterval in feature tests
src/shell/zsh_test.go	Updated tests to include RefreshInterval in feature tests
src/shell/bash_test.go	Updated tests to include RefreshInterval in feature tests
src/shell/fish_test.go	Updated tests to include RefreshInterval in feature tests
src/config/config_test.go	Added comprehensive tests for RefreshInterval feature

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/shell/scripts/omp.bash

src/shell/scripts/omp.fish

src/shell/scripts/omp.bash

src/shell/scripts/omp.fish

src/shell/scripts/omp.zsh

src/cli/init.go

Co-authored-by: Copilot <[email protected]>

Copilot

Pull Request Overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/shell/scripts/omp.bash

src/shell/scripts/omp.fish

src/shell/scripts/omp.zsh

Co-authored-by: Copilot <[email protected]>

Copilot

Pull Request Overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/shell/scripts/omp.fish

src/shell/scripts/omp.bash

src/shell/scripts/omp.zsh

Co-authored-by: Copilot <[email protected]>

Copilot

Pull Request Overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/shell/scripts/omp.bash

src/shell/scripts/omp.ps1

Co-authored-by: Copilot <[email protected]>

Copilot

Pull Request Overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.

src/shell/scripts/omp.zsh

Co-authored-by: Copilot <[email protected]>

Copilot

Pull Request Overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

src/shell/features.go:33

The stop condition Async*2 is now incorrect since RefreshInterval was added after Async. This will cause RefreshInterval to be excluded from the feature iteration. Update to RefreshInterval*2 or use a more maintainable approach that doesn't hardcode the last feature.

		if feature > Async*2 {

src/shell/scripts/omp.bash

Co-authored-by: Copilot <[email protected]>

Copilot

Pull Request Overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated 4 comments.

Comments suppressed due to low confidence (1)

src/shell/features.go:33

The hardcoded check Async*2 prevents the getAllFeatures() function from including the newly added RefreshInterval feature. Since RefreshInterval is now the last feature in the enum (after Async), the loop terminates before reaching it. This should be updated to RefreshInterval*2 to ensure all features are included.

		if feature > Async*2 {

Copilot · 2025-11-04T13:07:15Z

src/shell/scripts/omp.bash

+
+    # Convert milliseconds to seconds for bash (preserve sub-second precision)
+    local timeout_seconds=$(awk "BEGIN {print $interval/1000}")
+


Trailing whitespace detected on line 178. This should be removed for consistency with coding standards.

Suggested change

Copilot · 2025-11-04T13:07:15Z

src/shell/scripts/omp.fish

+
+    # Convert milliseconds to seconds for fish
+    set --local timeout_seconds (math "$interval / 1000.0")
+


Trailing whitespace detected on line 246. This should be removed for consistency with coding standards.

Suggested change

Copilot · 2025-11-04T13:07:15Z

src/shell/scripts/omp.bash

+            kill -WINCH $parent_pid  2>/dev/null
+        done
+    ) &
+


Trailing whitespace detected on line 192. This should be removed for consistency with coding standards.

Suggested change

Copilot · 2025-11-04T13:07:16Z

src/shell/scripts/omp.fish

+
+    function _omp_refresh_timer --on-signal SIGUSR1
+        omp_repaint_prompt
+    end
+


Trailing whitespace detected on line 250. This should be removed for consistency with coding standards.

Suggested change

function _omp_refresh_timer --on-signal SIGUSR1

omp_repaint_prompt

end

function _omp_refresh_timer --on-signal SIGUSR1

omp_repaint_prompt

end

feat(config): add refresh interval for periodic prompt updates

03d5b6a

Copilot AI review requested due to automatic review settings November 2, 2025 10:09

Copilot AI reviewed Nov 2, 2025

View reviewed changes

sanki92 mentioned this pull request Nov 2, 2025

Refresh Git widgets periodically #5036

Open

1 task

fix(bash): capture parent PID before subshell

a0ca87a

Co-authored-by: Copilot <[email protected]>

Copilot AI review requested due to automatic review settings November 2, 2025 10:19

sanki92 and others added 5 commits November 2, 2025 15:49

fix(fish): capture parent PID for signal delivery

4e1e72c

Co-authored-by: Copilot <[email protected]>

fix(bash): add exit trap to cleanup timer process

72079c3

Co-authored-by: Copilot <[email protected]>

fix(fish): add exit handler to cleanup timer process

b267bd8

Co-authored-by: Copilot <[email protected]>

refactor(zsh): remove unnecessary TMOUT export

81be569

Co-authored-by: Copilot <[email protected]>

refactor(cli): remove unused POSH_REFRESH_INTERVAL env var

1c398cf

Co-authored-by: Copilot <[email protected]>

Copilot AI reviewed Nov 2, 2025

View reviewed changes

src/shell/scripts/omp.bash Show resolved Hide resolved

src/shell/scripts/omp.bash Outdated Show resolved Hide resolved

src/shell/scripts/omp.fish Outdated Show resolved Hide resolved

src/shell/scripts/omp.zsh Outdated Show resolved Hide resolved

fix(bash): preserve sub-second precision in timer

fee5e77

Co-authored-by: Copilot <[email protected]>

Copilot AI review requested due to automatic review settings November 2, 2025 10:33

sanki92 and others added 2 commits November 2, 2025 16:03

fix(fish): preserve sub-second precision in timer

777c65d

Co-authored-by: Copilot <[email protected]>

fix(zsh): add validation for minimum refresh interval

a4a1baf

Co-authored-by: Copilot <[email protected]>

Copilot AI reviewed Nov 2, 2025

View reviewed changes

fix(fish): use $fish_pid for parent process reference

9dd103d

Co-authored-by: Copilot <[email protected]>

Copilot AI review requested due to automatic review settings November 2, 2025 13:41

sanki92 and others added 2 commits November 2, 2025 19:12

fix(fish): add variable check before killing timer process

7ce711c

Co-authored-by: Copilot <[email protected]>

fix(bash): verify variable exists before killing timer

91e4205

Co-authored-by: Copilot <[email protected]>

Copilot AI reviewed Nov 2, 2025

View reviewed changes

src/shell/scripts/omp.bash Show resolved Hide resolved

src/shell/scripts/omp.bash Outdated Show resolved Hide resolved

src/shell/scripts/omp.bash Show resolved Hide resolved

src/shell/scripts/omp.ps1 Show resolved Hide resolved

refactor(bash): scope _omp_refresh_pid as local variable

4797c37

Co-authored-by: Copilot <[email protected]>

Copilot AI review requested due to automatic review settings November 4, 2025 11:27

refactor(bash): scope parent_pid as local variable

47a41c0

Co-authored-by: Copilot <[email protected]>

Copilot AI reviewed Nov 4, 2025

View reviewed changes

src/shell/scripts/omp.zsh Outdated Show resolved Hide resolved

sanki92 and others added 4 commits November 4, 2025 17:02

fix(bash): prevent duplicate timer processes

fa44e3b

fix(pwsh): prevent duplicate timer and event registrations

af8d69f

style(zsh): remove trailing whitespace

6f7850e

fix(zsh): redirect warning message to stderr

c3472ea

Co-authored-by: Copilot <[email protected]>

Copilot AI review requested due to automatic review settings November 4, 2025 12:59

Copilot AI reviewed Nov 4, 2025

View reviewed changes

src/shell/scripts/omp.bash Outdated Show resolved Hide resolved

fix(bash): remove local keyword to allow trap access to PID

7aee74e

Co-authored-by: Copilot <[email protected]>

Copilot AI review requested due to automatic review settings November 4, 2025 13:05

Copilot AI reviewed Nov 4, 2025

View reviewed changes

JanDeDobbeleer force-pushed the main branch 9 times, most recently from 0f43b02 to fa38ae3 Compare November 7, 2025 15:30

JanDeDobbeleer force-pushed the main branch from 2e39b3d to baaec1b Compare November 16, 2025 15:18

JanDeDobbeleer force-pushed the main branch from 2af13bf to c7d35ad Compare November 30, 2025 19:23


		# Convert milliseconds to seconds for bash (preserve sub-second precision)
		local timeout_seconds=$(awk "BEGIN {print $interval/1000}")


		# Convert milliseconds to seconds for fish
		set --local timeout_seconds (math "$interval / 1000.0")

Uh oh!

feat(config): add refresh interval for periodic prompt updates #6938

Are you sure you want to change the base?

feat(config): add refresh interval for periodic prompt updates #6938

Conversation

sanki92 commented Nov 2, 2025

Prerequisites

Description

Issue

Problem

Solution

Changes Made

Testing

Usage Example

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Key Changes:

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees