Bug fix in Dart Analysis Server completion support, don't call completion_setSubscriptions() in startServer().#860
Closed
jwren wants to merge 1 commit intoJetBrains:masterfrom
Conversation
…tion_setSubscriptions() in startServer(). This PR changes this call to happen in serverConnected(), where the sdk version is sent back to the client.
Contributor
Author
Contributor
|
Good catch! Pushed, thanks. |
SergeyZh
pushed a commit
that referenced
this pull request
Mar 2, 2022
…ion_setSubscriptions() in startServer() close #860 (cherry picked from commit 07ae189d451b2360ddf73aaaff7c89972f5d5b14) IJ-CR-21597 GitOrigin-RevId: 29846a9b4efedd8e52a6df4877f565c7203fda88
SergeyZh
pushed a commit
that referenced
this pull request
Mar 4, 2022
…ion_setSubscriptions() in startServer() close #860 (cherry picked from commit 07ae189d451b2360ddf73aaaff7c89972f5d5b14) (cherry picked from commit 78c2f29ae109f4200866c979454884951438e4a3) GitOrigin-RevId: 1fec687d9d2772a441812cc4249b5e99803747b8
SergeyZh
pushed a commit
that referenced
this pull request
Mar 4, 2022
…ion_setSubscriptions() in startServer() close #860 (cherry picked from commit 07ae189d451b2360ddf73aaaff7c89972f5d5b14) (cherry picked from commit 78c2f29ae109f4200866c979454884951438e4a3) (cherry picked from commit 1fec687d9d2772a441812cc4249b5e99803747b8) GitOrigin-RevId: 97daaf17f6a60ac6ec214a1a1939c0979ab0dd93
SergeyZh
pushed a commit
that referenced
this pull request
Mar 4, 2022
…ion_setSubscriptions() in startServer() close #860 (cherry picked from commit 07ae189d451b2360ddf73aaaff7c89972f5d5b14) GitOrigin-RevId: 78c2f29ae109f4200866c979454884951438e4a3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes this call to happen in
serverConnected(), where the das version is sent back to the client.