The Dart plugin should use .dart_tool/package_config.json, instead of .packages#862
Closed
jwren wants to merge 1 commit intoJetBrains:masterfrom
Closed
The Dart plugin should use .dart_tool/package_config.json, instead of .packages#862jwren wants to merge 1 commit intoJetBrains:masterfrom
.dart_tool/package_config.json, instead of .packages#862jwren wants to merge 1 commit intoJetBrains:masterfrom
Conversation
Contributor
|
Merged, many thanks! If you have time, it would be great to add some tests. We seem to have some for .packages (search for .packages in test source files), I guess we could write similar ones for package_config.json |
13 tasks
SergeyZh
pushed a commit
that referenced
this pull request
Mar 22, 2022
…instead of .packages close #862 (cherry picked from commit 20d74450bd4df3ddd5837915bca879c3c5a74a12) GitOrigin-RevId: a0e595b5c65bb792ad723a8273998ef1c1539d0c
SergeyZh
pushed a commit
that referenced
this pull request
Mar 22, 2022
…instead of .packages close #862 (cherry picked from commit 20d74450bd4df3ddd5837915bca879c3c5a74a12) IJ-CR-22330 GitOrigin-RevId: bdbc7ddf2b5e1cec7c5963c76c7c298e35ee4f74
SergeyZh
pushed a commit
that referenced
this pull request
Mar 22, 2022
…instead of .packages close #862 (cherry picked from commit 20d74450bd4df3ddd5837915bca879c3c5a74a12) (cherry picked from commit a0e595b5c65bb792ad723a8273998ef1c1539d0c) GitOrigin-RevId: e934a8aadae62d9d30116ba86b83a6508217279f
SergeyZh
pushed a commit
that referenced
this pull request
Mar 22, 2022
…instead of .packages close #862 (cherry picked from commit 20d74450bd4df3ddd5837915bca879c3c5a74a12) IJ-CR-22330 GitOrigin-RevId: dc7c3858579cf1d132e8d9f7baf3c40e4e87b1df
| // need to protect '+' chars because URLDecoder.decode replaces '+' with space | ||
| final String encodedUriWithoutPluses = StringUtil.replace(rootUriValue + "/" + packageUriValue, "+", "%2B"); | ||
| final String uri = URLUtil.decode(encodedUriWithoutPluses); | ||
| final String packageUri = getAbsolutePackageRootPath(packageConfigJsonFile.getParent().getParent(), uri); |
Contributor
There was a problem hiding this comment.
@jwren Not sure packageConfigJsonFile.getParent().getParent() is correct here. See https://youtrack.jetbrains.com/issue/WEB-55363. I guess it should be packageConfigJsonFile.getParent().
intellij-monorepo-bot
pushed a commit
that referenced
this pull request
Apr 6, 2022
…s folder (follow-up on WEB-54703 and #862) GitOrigin-RevId: 1993d18a7f1a8e4d1b6f71ffc5614a97637d459a
intellij-monorepo-bot
pushed a commit
that referenced
this pull request
Apr 8, 2022
…s folder (follow-up on WEB-54703 and #862) (cherry picked from commit 1993d18a7f1a8e4d1b6f71ffc5614a97637d459a) IJ-CR-23164 GitOrigin-RevId: 4efb73dcca31a9bc0e5971bad8c795b8b9e7b0f0
intellij-monorepo-bot
pushed a commit
that referenced
this pull request
Apr 8, 2022
…s folder (follow-up on WEB-54703 and #862) (cherry picked from commit 1993d18a7f1a8e4d1b6f71ffc5614a97637d459a) IJ-CR-23164 GitOrigin-RevId: 9892d6c6b2dde0b31ff3ff5888d3f6ffc43d236b
intellij-monorepo-bot
pushed a commit
that referenced
this pull request
Apr 8, 2022
…s folder (follow-up on WEB-54703 and #862) (cherry picked from commit 1993d18a7f1a8e4d1b6f71ffc5614a97637d459a) IJ-CR-23164 GitOrigin-RevId: 3c4a37974be199be5cfd04c5ae308939890c2caa
intellij-monorepo-bot
pushed a commit
that referenced
this pull request
Apr 8, 2022
…s folder (follow-up on WEB-54703 and #862) (cherry picked from commit 1993d18a7f1a8e4d1b6f71ffc5614a97637d459a) IJ-CR-23164 GitOrigin-RevId: 341f36093ea21bd01f1abe7a2b8da31952e215b4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://youtrack.jetbrains.com/issue/WEB-54703
@alexander-doroshko