Open
Conversation
JoelOtter
reviewed
Jul 30, 2024
Owner
JoelOtter
left a comment
JoelOtter
left a comment
There was a problem hiding this comment.
Hey, thanks for this, seems like a good change! I would prefer the context handling be part of the same select statement - I understand it’s less efficient but this whole thing needs a big refactor anyway and I’m prioritising ease of change over performance at this point. :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would like to have control of the user interface via signalling. Preferably using context.
This PR adds a StartCtx that accepts a context that can be cancelled.