Add ignoreRepeat option to skip callback on held keys#1319
Open
nikoewe wants to merge 1 commit intoJohannesKlauss:mainfrom
Open
Add ignoreRepeat option to skip callback on held keys#1319nikoewe wants to merge 1 commit intoJohannesKlauss:mainfrom
nikoewe wants to merge 1 commit intoJohannesKlauss:mainfrom
Conversation
|
@nikoewe is attempting to deploy a commit to the Johannes Klauss' projects Team on Vercel. A member of the Team first needs to authorize it. |
Owner
|
Please add tests to this PR. |
Uses KeyboardEvent.repeat to detect when a key is being held down and skips the callback invocation when ignoreRepeat is enabled.
113480e to
25cd546
Compare
Author
|
@JohannesKlauss Updated the tests! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ignoreRepeatoption toOptionsthat prevents the hotkey callback from firing repeatedly when a key is held downKeyboardEvent.repeatproperty to detect held keys and early-returns from the listener whenignoreRepeatis enabledUsage
Test plan
ignoreRepeat: true, holding a key only fires the callback onceignoreRepeat: false), the default repeat behavior is unchangedkeyup,keydown, andpreventDefault