stylua --lsp should configure based on client rootUri, not the server CWD

[rmuir]

In the LSP mode, stylua processes configuration relative to the CWD of stylua --lsp process, instead of the root directory passed by the LSP client in the initialize request.

This can lead to reformatting code with the wrong style: e.g. falling back to internal defaults. Unless we are lucky, often the CWD of the server process doesn't match and won't have the correct configuration files pertaining to the sources in question.

See neovim/nvim-lspconfig#4082

[JohnnyMorganz]

I think this is indeed a bug, but these days stylua will actually try to first find configuration files closest to the file being formatted, and keep searching upwards until it reaches the config root (in this case, cwd).

So, if I understand correctly, this bug only happens if the LSP cwd was somewhere in between the actual workspace root and the formatted file. Is that right? If the LSP cwd is not an ancestor of the formatted file at all, I'd be surprised if this bug is happening.

[rmuir]

So, if I understand correctly, this bug only happens if the LSP cwd was somewhere in between the actual workspace root and the formatted file. Is that right? If the LSP cwd is not an ancestor of the formatted file at all, I'd be surprised if this bug is happening.

That was my use-case exactly:

/foo/.stylua.toml
/foo/bar/file1.lua
/foo/baz/file2.lua

• Workspace root: /foo/
• cwd: /foo/bar/

Invoking stylua --lsp --search-parent-directories also seemed like a potential workaround, at least for that specific case.