pre-commit with stylua-github fails to build for v0.14.0

[gegoune]

Hi, I just tried updating my pre-commit hook to use latest version

repos:
  - repo: https://github.com/johnnymorganz/stylua
    rev: v0.14.0
    hooks:
      - id: stylua-github

but got a failure from pip while running pre-commit

version information

pre-commit version: 2.20.0
git --version: git version 2.37.0
sys.version:
    3.10.5 (main, Jun 23 2022, 17:15:25) [Clang 13.1.6 (clang-1316.0.21.2.5)]
sys.executable: /usr/local/Cellar/pre-commit/2.20.0/libexec/bin/python3.10
os.name: posix
sys.platform: darwin

error information

An unexpected error has occurred: CalledProcessError: command: ('/Users/gegoune/.cache/pre-commit/repod4o1de3z/py_env-python3.10/bin/python', '-mpip', 'install', '.')
return code: 1
expected return code: 0
stdout:
    Processing /Users/gegoune/.cache/pre-commit/repod4o1de3z
      Installing build dependencies: started
      Installing build dependencies: finished with status 'done'
      Getting requirements to build wheel: started
      Getting requirements to build wheel: finished with status 'done'
      Preparing metadata (pyproject.toml): started
      Preparing metadata (pyproject.toml): finished with status 'done'
    Building wheels for collected packages: pseudo
      Building wheel for pseudo (pyproject.toml): started
      Building wheel for pseudo (pyproject.toml): finished with status 'error'
    Failed to build pseudo
    
stderr:
      error: subprocess-exited-with-error
      
      × Building wheel for pseudo (pyproject.toml) did not run successfully.
      │ exit code: 1
      ╰─> [16 lines of output]
          Traceback (most recent call last):
            File "/Users/gegoune/.cache/pre-commit/repod4o1de3z/py_env-python3.10/lib/python3.10/site-packages/pip/_vendor/pep517/in_process/_in_process.py", line 363, in <module>
              main()
            File "/Users/gegoune/.cache/pre-commit/repod4o1de3z/py_env-python3.10/lib/python3.10/site-packages/pip/_vendor/pep517/in_process/_in_process.py", line 345, in main
              json_out['return_val'] = hook(**hook_input['kwargs'])
            File "/Users/gegoune/.cache/pre-commit/repod4o1de3z/py_env-python3.10/lib/python3.10/site-packages/pip/_vendor/pep517/in_process/_in_process.py", line 261, in build_wheel
              return _build_backend().build_wheel(wheel_directory, config_settings,
            File "/private/var/folders/zm/t9yhs_ts7fzcyvm64l5zyk1w0000gn/T/pip-build-env-laywb0gg/overlay/lib/python3.10/site-packages/pseudo_builder.py", line 133, in build_wheel
              files = download(metadata)
            File "/private/var/folders/zm/t9yhs_ts7fzcyvm64l5zyk1w0000gn/T/pip-build-env-laywb0gg/overlay/lib/python3.10/site-packages/pseudo_builder.py", line 33, in download
              files = rg.download_asset(asset, extract_files=config.extract_files)
            File "/private/var/folders/zm/t9yhs_ts7fzcyvm64l5zyk1w0000gn/T/pip-build-env-laywb0gg/overlay/lib/python3.10/site-packages/release_gitter.py", line 354, in download_asset
              package = PackageAdapter(content_type, result)
            File "/private/var/folders/zm/t9yhs_ts7fzcyvm64l5zyk1w0000gn/T/pip-build-env-laywb0gg/overlay/lib/python3.10/site-packages/release_gitter.py", line 284, in __init__
              raise ValueError(f"Unknown or unsupported content type {content_type}")
          ValueError: Unknown or unsupported content type application/octet-stream
          [end of output]
      
      note: This error originates from a subprocess, and is likely not a problem with pip.
      ERROR: Failed building wheel for pseudo
    ERROR: Could not build wheels for pseudo, which is required to install pyproject.toml-based projects
    

I am not entirely sure whether it is due something not working on my system or affecting more people.

[JohnnyMorganz]

Sorry, not too familiar with precommit, but I will try to take a look at this some time

cc @IamTheFij, do you have any ideas here? as I think you know more about this than me

[ViViDboarder]

I’m seeing this too. It’s interesting. The file looks like it’s a zip file but the mine encoding doesn’t indicate it anymore. That’s how release-gitter detects how to extract the binary. I could probably add a way to hard code the extraction format.

[JohnnyMorganz]

I recently rewrote the release workflow which packages the assets (https://github.com/JohnnyMorganz/StyLua/blob/master/.github/workflows/release.yml)

It may have potentially changed the output. If the mime doesn't indicate it's a zip, that may be a problem on my end

[ViViDboarder]

Ah. I can see in the diff the mine type is set to asset_content_type: application/octet-stream explicitly. It should probably be application/zip.

[JohnnyMorganz]

Good spot, thanks. I will fix this

[gegoune]

I just tried to point pre-commit to master but same error still occurs. Does anything need to happen on your side for it to start working again?

Thanks for looking into it!

[JohnnyMorganz]

I just tried to point pre-commit to master but same error still occurs. Does anything need to happen on your side for it to start working again?

Thanks for looking into it!

It will need a new release with new artifacts being built. Will get a new release out soon hopefully. Alternatively you can use the system or base cargo versions

[JohnnyMorganz]

Should hopefully be fixed in v0.14.2: https://github.com/JohnnyMorganz/StyLua/releases/tag/v0.14.2