Fix var expression collapsing when containing comments#502
Merged
JohnnyMorganz merged 5 commits intomasterfrom Jul 20, 2022
Merged
Fix var expression collapsing when containing comments#502JohnnyMorganz merged 5 commits intomasterfrom
JohnnyMorganz merged 5 commits intomasterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #502 +/- ##
==========================================
- Coverage 97.66% 97.66% -0.01%
==========================================
Files 14 14
Lines 5351 5346 -5
==========================================
- Hits 5226 5221 -5
Misses 125 125
Continue to review full report at Codecov.
|
Contributor
Repo Comparison Testdiff --git ORI/zombie-strike/src/shared/ReplicatedStorage/Core/Settings.lua ALT/zombie-strike/src/shared/ReplicatedStorage/Core/Settings.lua
index ec53467..82c6568 100644
--- ORI/zombie-strike/src/shared/ReplicatedStorage/Core/Settings.lua
+++ ALT/zombie-strike/src/shared/ReplicatedStorage/Core/Settings.lua
@@ -123,7 +123,9 @@ function Settings.GetSettingIndex(settingName, player)
error("unknown setting " .. settingName)
else
- return LocalPlayer:WaitForChild("PlayerData", math.huge):WaitForChild("Settings"):WaitForChild(settingName).Value
+ return LocalPlayer:WaitForChild("PlayerData", math.huge)
+ :WaitForChild("Settings")
+ :WaitForChild(settingName).Value
end
end
|
matthargett
approved these changes
Jul 20, 2022
… var-expression-comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #500