improvements to roblox platform requires#1377
Open
hardlyardi wants to merge 3 commits intoJohnnyMorganz:mainfrom
Open
improvements to roblox platform requires#1377hardlyardi wants to merge 3 commits intoJohnnyMorganz:mainfrom
hardlyardi wants to merge 3 commits intoJohnnyMorganz:mainfrom
Conversation
added 2 commits
February 25, 2026 13:18
Author
|
some of the code in this PR is a bit of a mess, going to clean it up & fix the merge conflict |
|
PR wasnt even working lmao i forgot to pass in the setting outside of test cases |
|
sleep deprivation goes crazy bruh |
|
from looking at other code, i think this is the way to get the client config here? i'm not super familiar with this codebase yet though so please let me know if there's a better way, it seems like there r a bunch of ways to reference the client |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this pr adds support for require-by-string in roblox platform-specific requires (json, yaml, etc.)
sorry in advance for multi feature PR, I can split it up if needed, but I also added
luau-lsp.require.dataFilesUseLiteralStringsso someone can choose to have their required data files use singleton types.