Improvements for extracting @luau documentation#1386
Open
EternalAbby wants to merge 7 commits intoJohnnyMorganz:mainfrom
Open
Improvements for extracting @luau documentation#1386EternalAbby wants to merge 7 commits intoJohnnyMorganz:mainfrom
EternalAbby wants to merge 7 commits intoJohnnyMorganz:mainfrom
Conversation
Since it's harder to correctly determine where the functions are on the Luau site; they are put into block quotes, this change only changes the URL's fragment so that it directs to the library's section. - Changed links directing to the roblox docs site to the luau docs. - Import only the necessary methods. - Pretty-print the JSON file. - Explicitly close files after using them.
- Moved code for URL change. - Improved code comments. - Changed indent to 2 spaces to match `en-us.json`
Author
|
I'm not sure if I need to do the commits with the also, ignore the first commit being unverified, forgot to add signing key |
Owner
|
Unfortunately I can't accept the changes to |
Co-authored-by: JohnnyMorganz <johnnymorganz@outlook.com>
Co-authored-by: JohnnyMorganz <johnnymorganz@outlook.com>
Author
|
first time using pull requests so this is quite jank, sorry about that |
…c change when generating the luau json.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since it's harder to correctly determine where the library functions are on the Luau site; they are put into block quotes, this pull request mainly adds changes to the URL's fragment so that it directs to the library's section.
vectorlibrary having@robloxprefix instead of@luauin the luau generated json.This pull request is done to add ideas from #1357.