-
Notifications
You must be signed in to change notification settings - Fork 85
Calculation of CityBlockHash #7
Copy link
Copy link
Open
Description
In families/CityBlockHash.java, you calculate the hash with the following code (line 51):
hash[d] = (int) (vector.get(d)-randomPartition.get(d) / Double.valueOf(w));
I could be wrong here, but would you want parenthesis around the numerator? Otherwise order of operations takes precedence, which I'm not sure is correct.
Thanks. I'd be happy to put in a pull request for you, if need be.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels