-
-
Notifications
You must be signed in to change notification settings - Fork 85
Closed
Labels
area: toolingManaging the repository's maintenanceManaging the repository's maintenancestatus: accepting prsPlease, send a pull request to resolve this!Please, send a pull request to resolve this!type: bugSomething isn't working :(Something isn't working :(
Description
Bug Report Checklist
- I have tried restarting my IDE and the issue persists.
- I have pulled the latest
mainbranch of the repository. - I have searched for related issues and found none that matched my issue.
Overview
Codecov is a wonderful service that allows historical tracking of code coverage data. I use it in create-typescript-app and many other projects to upload code coverage data on every commit to main and PRs.
But, recent breaking changes to the first party Codecov GitHub Action have really messed with my ability to use it. It seems to now require a CODECOV_ACTION token for all repositories, even public open source ones.
This is disruptive. I filed codecov/codecov-action#1348 to suggest erroring by default and codecov/feedback#315 to give feedback on the breaking change.
In the meantime, this repo will have to either:
- tell users to add a
CODECOV_ACTIONtoken for code coverage tracking- And all my repositories will need to have that token added. 😮💨
- pin the Codecov action to v3
Additional Info
Brief notes on a few relevant issues and PRs:
- September 1st, 2023: use cli instead of node uploader codecov/codecov-action#1068 was sent to the Codecov repo to switch from the Codecov Node.js uploader to its CLI
- January 31st, 2024: https://github.com/codecov/codecov-action/releases/tag/v4.0.0 was released with that PR, explicitly removing support for tokenless uploading.
- The release notes indicate PRs made from forks to the upstream public repos will still support it. Some users are reporting that that's not the case.
- Notably, tokenless uploads aren't changed to fail the build. The action still passes with a no-op result.
- February >=3, 2024: Automated Renovate PRs start updating
create-typescript-apprepositories automatically to the new version. - February 14th, 2024: Provide clarity on future of tokenless uploads from GitHub Actions codecov/codecov-action#1293 was filed to ask the Codecov team for clarity on the situation
- March 12th, 2024: Document how to properly setup Codecov Github Action for OpenSource repositories codecov/feedback#301 was filed asking for clarity on how to set up the action
- March 30th, 2024: I filed fail_ci_if_error should default to true codecov/codecov-action#1348 and Feedback: communication around GitHub Action removing support for token-less uploads codecov/feedback#315
Metadata
Metadata
Assignees
Labels
area: toolingManaging the repository's maintenanceManaging the repository's maintenancestatus: accepting prsPlease, send a pull request to resolve this!Please, send a pull request to resolve this!type: bugSomething isn't working :(Something isn't working :(