make explicit that axes comparisons in tests ignore indices#357
make explicit that axes comparisons in tests ignore indices#357jishnub merged 2 commits intoJuliaArrays:masterfrom
Conversation
|
We may use |
|
Good point. I'm now using If one wanted to have it really fancy, one could define a new operator, for example |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #357 +/- ##
=======================================
Coverage 98.67% 98.67%
=======================================
Files 6 6
Lines 453 453
=======================================
Hits 447 447
Misses 6 6 ☔ View full report in Codecov by Sentry. |
|
The failing test is the unrelated |
|
It's a different issue related to floating-point precision, but indeed unrelated to this PR. |
This PR was suggested by @nsajko in JuliaLang/julia#54825. Currently Julia compares ranges only by comparing their values, not their indices, although they should also be taken into account for
AbstractVector. The tests in OffsetArrays.jl rely on this special behavior. This PR makes this explicit. It does not fix the brokenmapreducetest mentioned in #353.