Manually pass --check-bounds=yes to Pkg.test()

[DilumAluthge]

Needed after JuliaLang/Pkg.jl#4494.

[DilumAluthge]

Woo-hoo, all green CI!

[KristofferC]

Is all precompilation done by PkgEval so that it also runs with this option? So that the precompile files are valid.

[DilumAluthge]

Indeed. We pass --check-bounds=yes when precompiling:

PkgEval.jl/scripts/evaluate.jl

Lines 208 to 215 in 8fa8397

	# we load the package in a session mimicking Pkg's sandbox,
	# because that's what we previously precompiled the package for.
	println("Loading $(pkg.name)...")
	run(```$(Base.julia_cmd())
	--check-bounds=yes
	--inline=$(Bool(Base.JLOptions().can_inline) ? "yes" : "no")
	$(julia_args)
	-e $("using $(pkg.name)")```)

The PkgEval test suite includes a regression test for this:

PkgEval.jl/test/runtests.jl

Lines 176 to 178 in 8fa8397

	# make sure we only generated one package image
	@test isdir(compilecache)
	@test length(filter(endswith(".so"), readdir(compilecache))) == 1

If we only find one pkgimage, then that means we were able to use the same pkgimage for both the load (precompile) and test goals.