Revert "Use -Werror (with exceptions) on Windows builds"

[ararslan]

Reverts #484 per #484 (comment).

We can't build 1.12.0-rc3 binaries for Windows due to -Werror.

[ararslan]

@DilumAluthge, do you know whether anything else needs to happen in order for this to take effect? I retried the Windows builds for v1.12.0-rc3 and both failed on warnings with -Werror again.

[DilumAluthge]

Hmmm. Can you try deleting and recreating the tag?

[ararslan]

I retried the builds again to see if they miraculously work this time but if not then I'll try that.

[DilumAluthge]

@ararslan Did it end up working after another retry?

[ararslan]

Nope, perhaps unsurprisingly. I deleted and recreated the tag as you suggested and am still waiting for the Windows builds from that to start.

[DilumAluthge]

Once you've confirmed that the Windows builds succeeded, let me know, and I'll create Buildkite release branches for 1.{10-12}

[ararslan]

Windows builds succeeded and tests nearing completion! 🎉

[ararslan]

We're all good now. Thanks so much for your help, @DilumAluthge!

[topolarity]

Thanks for fixing this up folks! (sorry for the breakage)

Any progress with splitting this so that we can un-revert on julialang/master?

[DilumAluthge]

Any progress with splitting this so that we can un-revert on julialang/master?

I'll work on creating the release branches, after which we can re-land.

[DilumAluthge]

I've pushed release branches to this repo for:

• release-julia.1.10
• release-julia-1.11
• release-julia-1.12

But we won't actually start using those branches until the corresponding PRs are merged:

• CI 1.10: Use the 1.10-specific Buildkite branch JuliaLang/julia#59761 (which is now included in Backports for Julia 1.10.11 JuliaLang/julia#58889)
• CI 1.11: Use the 1.11-specific Buildkite branch JuliaLang/julia#59760 (which is now included in Backports for Julia 1.11.8 JuliaLang/julia#59521)
• CI 1.12: Use the 1.12-specific Buildkite branch JuliaLang/julia#59759 (which is now included in Backports for 1.12.1 JuliaLang/julia#59705)

[DilumAluthge]

I'm going to wait to merge JuliaLang/julia#59759 until after 1.12.0 has been released, to avoid breaking anything during this last part of the release process.

And we should hold off on re-landing #484 until after JuliaLang/julia#59759 has been merged.

[ararslan]

Would it make sense for the branch names to match those on the Julia repo? So e.g. release-1.12 instead of release-julia-1.12. Probably doesn't matter

[DilumAluthge]

Would it make sense for the branch names to match those on the Julia repo? So e.g. release-1.12 instead of release-julia-1.12. Probably doesn't matter

IIRC, this was intentional, to avoid confusion between branches in JuliaLang/julia and branches in JuliaCI/julia-buildkite.

[DilumAluthge]

Alright, all three backports branches are now using the release-julia-* branches in this repo.

Specifically:

1. Julia 1.10: JuliaLang/julia@6901dde is included in Backports for Julia 1.10.11 JuliaLang/julia#58889
2. Julia 1.11: JuliaLang/julia@58327cc is included in Backports for Julia 1.11.8 JuliaLang/julia#59521
3. Julia 1.12: JuliaLang/julia@bac8fca is included in Backports for 1.12.1 JuliaLang/julia#59705

@topolarity Can you re-land your PR now?