Skip to content

Make show method for CategoricalValue three-argument#436

Open
andreasnoack wants to merge 4 commits intomasterfrom
an/show
Open

Make show method for CategoricalValue three-argument#436
andreasnoack wants to merge 4 commits intomasterfrom
an/show

Conversation

@andreasnoack
Copy link
Member

@andreasnoack andreasnoack commented Feb 14, 2026 •
edited
Loading

Also, adjust two-argument show method for CategoricalPool such that it produces parseable results. With this change, I'm getting

julia> [String7("placebo")]
1-element Vector{String7}:
 "placebo"

julia> categorical([String7("placebo")])
1-element CategoricalArray{String7,1,UInt32}:
 "placebo"

Closes #435

@andreasnoack
Make show method CategoricalValue three-argument
03c04f0 
Also, adjust two-argument show method for CategoricalPool such
that it produces parseable results.
@andreasnoack andreasnoack changed the title Make show method CategoricalValue three-argument Make show method for CategoricalValue three-argument Feb 14, 2026
nalimilan
nalimilan reviewed Feb 18, 2026
View reviewed changes
Copy link
Member

@nalimilan nalimilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

andreasnoack and others added 2 commits February 19, 2026 09:32
@andreasnoack
Test exact repr strings for CategoricalValue
073d0d9
@andreasnoack @nalimilan
Apply suggestion from @nalimilan
46ad3a7 
Co-authored-by: Milan Bouchet-Valat <nalimilan@club.fr>
nalimilan
nalimilan reviewed Feb 19, 2026
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nalimilan nalimilan nalimilan left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

show method issues for CategoricalValue

2 participants

@andreasnoack @nalimilan