Skip to content

Conversation

@felixcremer
Copy link
Member

This uses dispatch to use the previous version on proper Matrix aout and to use similar to construct a Matrix and to then use the Matrix based method, because I did not like the if clause on type information.
Could you give me some hint, how I could be testing this functionality?
Where is the readblock! function used and how could I force it to not use a proper Matrix?

This uses dispatch to use the previous version on proper Matrix aout
and to use similar to construct a Matrix and to then use the Matrix based method.
@felixcremer felixcremer marked this pull request as ready for review February 21, 2023 16:01
@felixcremer felixcremer requested a review from meggart February 21, 2023 16:01
@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

Base: 52.36% // Head: 51.75% // Decreases project coverage by -0.62% ⚠️

Coverage data is based on head (0922779) compared to base (59f9af5).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #20      +/-   ##
==========================================
- Coverage   52.36%   51.75%   -0.62%     
==========================================
  Files          13       13              
  Lines         338      342       +4     
==========================================
  Hits          177      177              
- Misses        161      165       +4     
Impacted Files Coverage Δ
src/datasets/archgdal.jl 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@felixcremer felixcremer merged commit c9d7d6d into master Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants